Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45116: Make --inlinestat option available in build.bat for diagnostic logs #31436

Closed
wants to merge 2 commits into from
Closed

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Feb 20, 2022

MSVC seems to abort function inlining in _PyEval_EvalFrameDefault() not only when PGO building but even Release mode.
To check the regression, it'll be helpful if 3.10 and main git-branches have inlining reports in their build logs.

https://bugs.python.org/issue45116

@neonene neonene requested a review from a team as a code owner February 20, 2022 03:30
@the-knights-who-say-ni

This comment was marked as resolved.

@neonene neonene changed the title bpo-45116: Add a build option to display core function's inlinees on Windows bpo-45116: Make --inlinestat option available in build.bat for diagnostic logs Feb 20, 2022
@neonene
Copy link
Contributor Author

neonene commented Feb 25, 2022

An alternative is to set an envvar at .github/workflows/build.yml leaving build.bat as it is.

@neonene
Copy link
Contributor Author

neonene commented Mar 18, 2022

This is no longer applicable as the GitHub CI is debug mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants