Infra: Make colour theme cycler button accessible #2619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
https://web.dev/measure/?url=https%3A%2F%2Fpeps.python.org
After
https://web.dev/measure/?url=https%3A%2F%2Fpep-previews--2619.org.readthedocs.build%2F
Fix
Fixed following advice from https://kittygiraudel.com/2020/12/10/accessible-icon-links/
<span class="visually-hidden">Toggle light / dark / auto colour theme</span>
to the buttonvisually-hidden
CSS class from Furo which is pretty similar to the one from the blogaria-hidden="true"
to the SVGs so they are hidden from screen readers