Infra: Make colour theme cycler button accessible #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps a naive question, but surely the visual theme doesn't matter for blind users (when a screen reader is used)? I'd prefer to just entirely hide the chooser subcomponent from screen readers, rather than adding a CSS work-around ("visually-hidden"). A |
|
It's a good question!
https://adrianroselli.com/2017/02/not-all-screen-reader-users-are-blind.html |
|
@AA-Turner Any further thoughts/questions? |
carljm
added a commit
to carljm/peps
that referenced
this pull request
Jun 27, 2022
* main: (47 commits) PEP 668: Address feedback and mark as accepted (python#2673) PEP-0691 Gramatical changes + `meta` key description under Project List (python#2677) PEP691: Mark Accepted + Grammar Fixes + Small Fix (python#2674) PEP 691: touch up (python#2668) PEP 650: Withdraw and move to Standards Track (python#2665) PEP 561: Mark as final (python#2663) PEP 660: Mark as Final (python#2664) PEP 615: Fix incorrect RFC link (python#2662) Multiple PEPs: Move Packaging PEPs to Standards Track and mark as Final (python#2657) PEP 671: Since it keeps getting asked about, add a para on deferreds (python#2661) Infra: Tweak PEP references to work on topic sub-index pages (python#2658) PEP 632: Remove `Topic: Packaging` header (python#2656) Infra: Make colour theme cycler button accessible (python#2619) PEP 593: Fix citation references (python#2640) PEP 553: Fix citation references (python#2639) PEP 668: Add PEP-Delegate (python#2654) PEP 693: Python 3.12 Release Schedule (python#2648) Add support for topic indices (python#2579) PEP691: Switch to a List for Project, Address more Feedback (python#2653) PEP 671: Add section on evaluation order (python#2652) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
https://web.dev/measure/?url=https%3A%2F%2Fpeps.python.org
After
https://web.dev/measure/?url=https%3A%2F%2Fpep-previews--2619.org.readthedocs.build%2F
Fix
Fixed following advice from https://kittygiraudel.com/2020/12/10/accessible-icon-links/
<span class="visually-hidden">Toggle light / dark / auto colour theme</span>to the buttonvisually-hiddenCSS class from Furo which is pretty similar to the one from the blogaria-hidden="true"to the SVGs so they are hidden from screen readers