Fix asyncio executor types
#13616
Merged
Fix asyncio executor types
#13616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update type annotations for `run_in_executor` and `set_default_executor` in asyncio event loop interfaces to use more specific executor types from `concurrent.futures`
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
CI failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Anyinrun_in_executor, which should beExecutor | None. See docs here. The default executor is used ifNoneis specifically provided. We're doing this both in the concreteBaseEventLoopand theAbstractEventLoop.ThreadPoolExecutoras the sole argument annotation forset_default_executoronBaseEventLoop. Technically we could type this asExecutorin prior versions however considering passing non thread-pool executors as arguments has been deprecated since 3.8 I don't see any value in adding a deprecated pre 3.11 overload.Executoras the sole argument annotation forset_default_executoronAbstractEventLoop. Despite breaking the liskov substitution principle it seems valuable to me to maintain the fact that third party libraries are able to use non thread pool executors in their own custom event loops, open to changing this however.