Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type for GenericAlias.__origin__ for type aliases parameterised with a type #13619

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Fix return type for GenericAlias.__origin__ for type aliases parameterised with a type #13619

merged 2 commits into from
Mar 11, 2025

Conversation

danpascu
Copy link
Contributor

Fixes #13618

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit d04d532 into python:main Mar 11, 2025
55 checks passed
@danpascu danpascu deleted the danpascu-fix-generic-alias-origin branch March 11, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The __origin__ attribute of GenericAlias has the wrong type for type aliases
2 participants
@danpascu @srittau