Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify progress data #972

Merged
merged 6 commits into from
May 10, 2023
Merged

Unify progress data #972

merged 6 commits into from
May 10, 2023

Conversation

qarmin
Copy link
Owner

@qarmin qarmin commented May 9, 2023

  • Unify receivers/senders data from core to gui about progress
  • Unify functions to create tree views
  • Fix problem with invalid sorting of columns in bad extension tool
  • Speedup folder/file search by avoiding using too big number of atomic writes
  • Added ability to set number of threads in CLI

@qarmin qarmin marked this pull request as ready for review May 9, 2023 16:23
@qarmin
Copy link
Owner Author

qarmin commented May 9, 2023

Looks that on i7 4770 (4/8) and cheap ssd, finding files and reading its metadata is quite optimal with 8 threads(by default this is equal to number of threads)

Benchmark 1: target/release/czkawka_cli big -d /home/rafal -T 1
  Time (mean ± σ):      8.067 s ±  0.119 s    [User: 3.341 s, System: 4.693 s]
  Range (min … max):    7.973 s …  8.260 s    5 runs
 
Benchmark 2: target/release/czkawka_cli big -d /home/rafal -T 2
  Time (mean ± σ):      4.773 s ±  0.034 s    [User: 3.445 s, System: 4.622 s]
  Range (min … max):    4.731 s …  4.808 s    5 runs
 
Benchmark 3: target/release/czkawka_cli big -d /home/rafal -T 3
  Time (mean ± σ):      4.040 s ±  0.028 s    [User: 3.530 s, System: 5.084 s]
  Range (min … max):    4.008 s …  4.070 s    5 runs
 
Benchmark 4: target/release/czkawka_cli big -d /home/rafal -T 4
  Time (mean ± σ):      3.754 s ±  0.055 s    [User: 3.804 s, System: 5.646 s]
  Range (min … max):    3.677 s …  3.817 s    5 runs
 
Benchmark 5: target/release/czkawka_cli big -d /home/rafal -T 5
  Time (mean ± σ):      3.464 s ±  0.167 s    [User: 4.092 s, System: 5.997 s]
  Range (min … max):    3.167 s …  3.562 s    5 runs
 
Benchmark 6: target/release/czkawka_cli big -d /home/rafal -T 6
  Time (mean ± σ):      3.343 s ±  0.133 s    [User: 4.038 s, System: 6.396 s]
  Range (min … max):    3.113 s …  3.454 s    5 runs
 
Benchmark 7: target/release/czkawka_cli big -d /home/rafal -T 7
  Time (mean ± σ):      3.378 s ±  0.135 s    [User: 4.269 s, System: 6.498 s]
  Range (min … max):    3.265 s …  3.600 s    5 runs
 
Benchmark 8: target/release/czkawka_cli big -d /home/rafal -T 8
  Time (mean ± σ):      2.691 s ±  0.168 s    [User: 4.245 s, System: 6.840 s]
  Range (min … max):    2.595 s …  2.984 s    5 runs
 
Benchmark 9: target/release/czkawka_cli big -d /home/rafal -T 9
  Time (mean ± σ):      2.798 s ±  0.012 s    [User: 4.188 s, System: 6.735 s]
  Range (min … max):    2.781 s …  2.809 s    5 runs
 
Benchmark 10: target/release/czkawka_cli big -d /home/rafal -T 10
  Time (mean ± σ):      2.817 s ±  0.026 s    [User: 4.149 s, System: 6.747 s]
  Range (min … max):    2.795 s …  2.849 s    5 runs
 
Benchmark 11: target/release/czkawka_cli big -d /home/rafal -T 11
  Time (mean ± σ):      2.812 s ±  0.020 s    [User: 4.136 s, System: 6.789 s]
  Range (min … max):    2.788 s …  2.841 s    5 runs
 
Benchmark 12: target/release/czkawka_cli big -d /home/rafal -T 12
  Time (mean ± σ):      2.825 s ±  0.015 s    [User: 4.118 s, System: 6.837 s]
  Range (min … max):    2.808 s …  2.839 s    5 runs

@qarmin qarmin force-pushed the unify_progress_data branch from 62a9f77 to a0e97a1 Compare May 10, 2023 19:01
@qarmin qarmin merged commit 582e541 into master May 10, 2023
@qarmin qarmin deleted the unify_progress_data branch May 10, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant