Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send client and rust version to server #201

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

tellet-q
Copy link
Contributor

  • Introduce a new dependency rustc_version to fetch Rust version.
  • Extend user-agent header with info about client and rust versions, do it while creating a Channel

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡🫡

@tellet-q tellet-q requested a review from timvisee December 10, 2024 11:12
@tellet-q tellet-q merged commit 2f0ef44 into dev Dec 10, 2024
2 checks passed
@tellet-q tellet-q deleted the client-version-to-server-2 branch December 10, 2024 11:19
timvisee pushed a commit that referenced this pull request Jan 16, 2025
* Send client and rust version to server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants