[3d] Large scene support: shift scene's origin if the camera got too far #60869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Tests failed for Qt 5One or more tests failed using the build from commit cb82929 4978_line_rendering_2 (testEpsg4978LineRendering)4978_line_rendering_2Test failed at testEpsg4978LineRendering at tests/src/3d/testqgs3drendering.cpp:1838
The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
uclaros
reviewed
Mar 6, 2025
This should greatly improve our capability to handle large scenes (e.g. more than 50km across) Also add a checkbox to the debug panel to allow devs temporarily turn it off.
wonder-sk
force-pushed
the
auto-shift-origin
branch
from
cb82929 to
e447b59
Compare
for more information, see https://pre-commit.ci
Relax the assumption that origin is always in the center of the scene
Origin may get updated in Qgs3DMapScene constructor, so let's set ours once the Qgs3DMapScene is constructed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "origin rebasing" or "origin shifting" technique is commonly used in various 3D engines when dealing with large scenes (where objects need double precision coordinates). It should greatly improve our capability to handle large scenes (e.g. more than 50km across)
For now, I have used a simple rule that when camera gets 10 km away from the world's origin, the origin is shifted (and camera is placed at the origin). The origin shift has a bit of a cost (we're updating 4x4 transform matrices of all active nodes), so we prefer not to do it on every camera change, but only when necessary. That said, I have not seen slowdowns when origin gets shifted.
Also add a checkbox to the debug panel to allow devs temporarily turn it off.
A related philosophical question from Futurama:
Before:
simplescreenrecorder-2025-03-05_15.31.36.mp4
After:
simplescreenrecorder-2025-03-05_15.34.44.mp4