Gizmo2: add convenient default methods to ClassOutput #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Mar 11, 2025
mkouba
commented
- these methods accept FQCN instead of ClassDesc
- these methods accept FQCN instead of ClassDesc
dmlloyd
approved these changes
Mar 11, 2025
gsmet
reviewed
Mar 11, 2025
| * @param builder the | ||
| * @return the descriptor | ||
| */ | ||
| default ClassDesc class_(String name, Consumer<ClassCreator> builder) { |
There was a problem hiding this comment.
Sorry for asking out of the blue, but I was wondering if we should go with things like createClass instead of class_? Now maybe this is coming from the Class File API but it's not very pretty?
Note that this might be a completely stupid question as I haven't looked at the API in depth but I think it's probably now or never to ask this question.
There was a problem hiding this comment.
It's not stupid at all. We should think about a good strategy because it's not only class that is reserved and cannot be used "as is". I have to admit that I like the concise underscore suffix strategy but I agree that it does not feel very "Java"-like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.