Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse By Workflow #4347

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Browse By Workflow #4347

wants to merge 8 commits into from

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Mar 5, 2025

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 3.81679% with 126 lines in your changes missing coverage. Please review.

Project coverage is 38.97%. Comparing base (b06c17f) to head (4cbdec6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
catalog/app/containers/Bucket/Workflows/Detail.tsx 0.00% 42 Missing ⚠️
...og/app/containers/Bucket/PackageSearchRedirect.tsx 0.00% 31 Missing ⚠️
catalog/app/containers/Bucket/Workflows/index.tsx 0.00% 22 Missing ⚠️
catalog/app/containers/Bucket/Workflows/List.tsx 0.00% 15 Missing ⚠️
catalog/app/containers/Search/model.ts 28.57% 5 Missing ⚠️
catalog/app/constants/routes.ts 42.85% 4 Missing ⚠️
catalog/app/containers/Bucket/Bucket.js 0.00% 3 Missing ⚠️
...Bucket/Workflows/gql/WorkflowPackages.generated.ts 0.00% 2 Missing ⚠️
catalog/app/containers/Search/Search.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4347      +/-   ##
==========================================
- Coverage   39.10%   38.97%   -0.13%     
==========================================
  Files         787      792       +5     
  Lines       34827    34950     +123     
  Branches     5316     5330      +14     
==========================================
+ Hits        13618    13622       +4     
- Misses      20666    20785     +119     
  Partials      543      543              
Flag Coverage Δ
api-python 91.41% <ø> (ø)
catalog 18.02% <3.81%> (-0.08%) ⬇️
lambda 91.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant