Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambdas: bump pydantic to v2 #4355

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Mar 10, 2025

Description

TODO

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.10%. Comparing base (0912c12) to head (37dc65f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4355    +/-   ##
========================================
  Coverage   39.10%   39.10%            
========================================
  Files         787      787            
  Lines       34827    34827            
  Branches     5316     5525   +209     
========================================
  Hits        13618    13618            
+ Misses      20666    20026   -640     
- Partials      543     1183   +640     
Flag Coverage Δ
api-python 91.41% <ø> (ø)
catalog 18.09% <ø> (ø)
lambda 91.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sir-sigurd sir-sigurd marked this pull request as ready for review March 11, 2025 11:57
@sir-sigurd sir-sigurd requested a review from nl0 March 11, 2025 11:57
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated Pydantic from v1 to v2 across lambda functions while maintaining backward compatibility through the v1 compatibility layer.

  • Modified imports in lambdas/pkgpush/src/t4_lambda_pkgpush/__init__.py and lambdas/s3hash/src/t4_lambda_s3hash/__init__.py to use pydantic.v1 namespace
  • Updated dependencies in both lambdas' setup.py to use pydantic ~= 2.10
  • Added new dependencies annotated-types and pydantic-core in requirements.txt
  • Updated quilt_shared dependency hash to support Pydantic v2
  • Added changelog entries documenting the Pydantic version bump

8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@sir-sigurd sir-sigurd enabled auto-merge March 11, 2025 12:06
@sir-sigurd sir-sigurd added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@sir-sigurd sir-sigurd added this pull request to the merge queue Mar 11, 2025
Merged via the queue into master with commit d9a8b4a Mar 11, 2025
37 checks passed
@sir-sigurd sir-sigurd deleted the bump-pydantic-use-v1-lambdas branch March 11, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants