Remove incorrect spurious migration handling #1144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case is handled by the usual path validation timeout, and by the ACK elicited from the peer by a PATH_CHALLENGE on a legitimate path.
Context:
§9.3.2:
§9.3.3:
§1.2:
§9.1
§9.2
So if a spurious migration occurs, we (already) send a PATH_CHALLENGE on the previous path, the peer ACKs it, and that non-probing packet triggers a new migration back to the legitimate path. Or, alternatively, the path validation timer expires for the new path and we revert to the legitimate one.
Thanks to @Matthias247 for helping identify this!