Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from kubebuilder v3.6.0 to v3.7.0 #18

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Upgrade from kubebuilder v3.6.0 to v3.7.0 #18

merged 2 commits into from
Jan 4, 2023

Conversation

int128
Copy link
Member

@int128 int128 commented Jan 4, 2023

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

diff

  • config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-proxy-role.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-manager-rolebinding.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-proxy-rolebinding.yaml
  • config/default/rbac.authorization.k8s.io_v1_role_google-cloud-pubsub-operator-leader-election-role.yaml
  • config/default/rbac.authorization.k8s.io_v1_rolebinding_google-cloud-pubsub-operator-leader-election-rolebinding.yaml
  • config/default/v1_configmap_google-cloud-pubsub-operator-manager-config.yaml (Deleted)
  • config/default/v1_namespace_google-cloud-pubsub-operator-system.yaml
  • config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml
  • config/default/v1_serviceaccount_google-cloud-pubsub-operator-controller-manager.yaml

config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml
@@ -2,6 +2,12 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   labels:
+    app.kubernetes.io/component: manager
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: controller-manager
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: deployment
+    app.kubernetes.io/part-of: hello-kubebuilder
     control-plane: controller-manager
   name: google-cloud-pubsub-operator-controller-manager
   namespace: google-cloud-pubsub-operator-system
@@ -17,6 +23,22 @@ spec:
       labels:
         control-plane: controller-manager
     spec:
+      affinity:
+        nodeAffinity:
+          requiredDuringSchedulingIgnoredDuringExecution:
+            nodeSelectorTerms:
+            - matchExpressions:
+              - key: kubernetes.io/arch
+                operator: In
+                values:
+                - amd64
+                - arm64
+                - ppc64le
+                - s390x
+              - key: kubernetes.io/os
+                operator: In
+                values:
+                - linux
       containers:
       - args:
         - --secure-listen-address=0.0.0.0:8443

config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml
@@ -1,6 +1,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
+  labels:
+    app.kubernetes.io/component: kube-rbac-proxy
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: metrics-reader
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: clusterrole
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-metrics-reader
 rules:
 - nonResourceURLs:

config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-proxy-role.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-proxy-role.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-proxy-role.yaml
@@ -1,6 +1,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
+  labels:
+    app.kubernetes.io/component: kube-rbac-proxy
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: proxy-role
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: clusterrole
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-proxy-role
 rules:
 - apiGroups:

config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-manager-rolebinding.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-manager-rolebinding.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-manager-rolebinding.yaml
@@ -1,6 +1,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
+  labels:
+    app.kubernetes.io/component: rbac
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: manager-rolebinding
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: clusterrolebinding
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-manager-rolebinding
 roleRef:
   apiGroup: rbac.authorization.k8s.io

config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-proxy-rolebinding.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-proxy-rolebinding.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-proxy-rolebinding.yaml
@@ -1,6 +1,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
+  labels:
+    app.kubernetes.io/component: kube-rbac-proxy
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: proxy-rolebinding
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: clusterrolebinding
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-proxy-rolebinding
 roleRef:
   apiGroup: rbac.authorization.k8s.io

config/default/rbac.authorization.k8s.io_v1_role_google-cloud-pubsub-operator-leader-election-role.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/rbac.authorization.k8s.io_v1_role_google-cloud-pubsub-operator-leader-election-role.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/rbac.authorization.k8s.io_v1_role_google-cloud-pubsub-operator-leader-election-role.yaml
@@ -1,6 +1,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
+  labels:
+    app.kubernetes.io/component: rbac
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: leader-election-role
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: role
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-leader-election-role
   namespace: google-cloud-pubsub-operator-system
 rules:

config/default/rbac.authorization.k8s.io_v1_rolebinding_google-cloud-pubsub-operator-leader-election-rolebinding.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/rbac.authorization.k8s.io_v1_rolebinding_google-cloud-pubsub-operator-leader-election-rolebinding.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/rbac.authorization.k8s.io_v1_rolebinding_google-cloud-pubsub-operator-leader-election-rolebinding.yaml
@@ -1,6 +1,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
+  labels:
+    app.kubernetes.io/component: rbac
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: leader-election-rolebinding
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: rolebinding
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-leader-election-rolebinding
   namespace: google-cloud-pubsub-operator-system
 roleRef:

config/default/v1_configmap_google-cloud-pubsub-operator-manager-config.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/v1_configmap_google-cloud-pubsub-operator-manager-config.yaml
+++ /dev/null
@@ -1,28 +0,0 @@
-apiVersion: v1
-data:
-  controller_manager_config.yaml: |
-    apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
-    kind: ControllerManagerConfig
-    health:
-      healthProbeBindAddress: :8081
-    metrics:
-      bindAddress: 127.0.0.1:8080
-    webhook:
-      port: 9443
-    leaderElection:
-      leaderElect: true
-      resourceName: b0b34645.quipper.github.io
-    # leaderElectionReleaseOnCancel defines if the leader should step down volume
-    # when the Manager ends. This requires the binary to immediately end when the
-    # Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
-    # speeds up voluntary leader transitions as the new leader don't have to wait
-    # LeaseDuration time first.
-    # In the default scaffold provided, the program ends immediately after
-    # the manager stops, so would be fine to enable this option. However,
-    # if you are doing or is intended to do any operation such as perform cleanups
-    # after the manager stops then its usage might be unsafe.
-    # leaderElectionReleaseOnCancel: true
-kind: ConfigMap
-metadata:
-  name: google-cloud-pubsub-operator-manager-config
-  namespace: google-cloud-pubsub-operator-system

config/default/v1_namespace_google-cloud-pubsub-operator-system.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/v1_namespace_google-cloud-pubsub-operator-system.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/v1_namespace_google-cloud-pubsub-operator-system.yaml
@@ -2,5 +2,11 @@ apiVersion: v1
 kind: Namespace
 metadata:
   labels:
+    app.kubernetes.io/component: manager
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: system
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: namespace
+    app.kubernetes.io/part-of: hello-kubebuilder
     control-plane: controller-manager
   name: google-cloud-pubsub-operator-system

config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml
@@ -2,6 +2,12 @@ apiVersion: v1
 kind: Service
 metadata:
   labels:
+    app.kubernetes.io/component: kube-rbac-proxy
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/instance: controller-manager-metrics-service
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: service
+    app.kubernetes.io/part-of: hello-kubebuilder
     control-plane: controller-manager
   name: google-cloud-pubsub-operator-controller-manager-metrics-service
   namespace: google-cloud-pubsub-operator-system

config/default/v1_serviceaccount_google-cloud-pubsub-operator-controller-manager.yaml

--- a/tmp/kustomize-action-oH70ed/config/default/v1_serviceaccount_google-cloud-pubsub-operator-controller-manager.yaml
+++ b/tmp/kustomize-action-5iOdMo/config/default/v1_serviceaccount_google-cloud-pubsub-operator-controller-manager.yaml
@@ -1,5 +1,12 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
+  labels:
+    app.kuberentes.io/instance: controller-manager
+    app.kubernetes.io/component: rbac
+    app.kubernetes.io/created-by: hello-kubebuilder
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: serviceaccount
+    app.kubernetes.io/part-of: hello-kubebuilder
   name: google-cloud-pubsub-operator-controller-manager
   namespace: google-cloud-pubsub-operator-system

@int128 int128 marked this pull request as ready for review January 4, 2023 01:43
@int128 int128 merged commit c1cbca1 into main Jan 4, 2023
@int128 int128 deleted the upgrade-kubebuilder-v3.7.0 branch January 4, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@int128