Notify deadline exceeded error on subscription creation #180
+43
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int128
force-pushed
the
int128/notice-subscription-takes-long-time
branch
from
5716aef to
1baedd2
Compare
int128
changed the title
This comment has been minimized.
This comment has been minimized.
int128
commented
Nov 30, 2023
| @@ -23,15 +23,19 @@ import ( | |||
| // SubscriptionSpec defines the desired state of Subscription | |||
| type SubscriptionSpec struct { | |||
| // subscription ID | |||
| //+kubebuilder:validation:XValidation:message="Immutable field",rule="self == oldSelf" | |||
int128
force-pushed
the
int128/notice-subscription-takes-long-time
branch
from
6f7444c to
eea831c
Compare
diff
config/default/apiextensions.k8s.io_v1_customresourcedefinition_subscriptions.googlecloudpubsuboperator.quipper.github.io.yaml--- a/tmp/kustomize-action-YPfXQV/config/default/apiextensions.k8s.io_v1_customresourcedefinition_subscriptions.googlecloudpubsuboperator.quipper.github.io.yaml
+++ b/tmp/kustomize-action-mRgcaV/config/default/apiextensions.k8s.io_v1_customresourcedefinition_subscriptions.googlecloudpubsuboperator.quipper.github.io.yaml
@@ -36,15 +36,27 @@ spec:
subscriptionID:
description: subscription ID
type: string
+ x-kubernetes-validations:
+ - message: Immutable field
+ rule: self == oldSelf
subscriptionProjectID:
description: project ID of subscription
type: string
+ x-kubernetes-validations:
+ - message: Immutable field
+ rule: self == oldSelf
topicID:
description: topic ID
type: string
+ x-kubernetes-validations:
+ - message: Immutable field
+ rule: self == oldSelf
topicProjectID:
description: project ID of topic
type: string
+ x-kubernetes-validations:
+ - message: Immutable field
+ rule: self == oldSelf
type: object
status:
description: SubscriptionStatus defines the observed state of Subscriptionconfig/default/apiextensions.k8s.io_v1_customresourcedefinition_topics.googlecloudpubsuboperator.quipper.github.io.yaml--- a/tmp/kustomize-action-YPfXQV/config/default/apiextensions.k8s.io_v1_customresourcedefinition_topics.googlecloudpubsuboperator.quipper.github.io.yaml
+++ b/tmp/kustomize-action-mRgcaV/config/default/apiextensions.k8s.io_v1_customresourcedefinition_topics.googlecloudpubsuboperator.quipper.github.io.yaml
@@ -36,9 +36,15 @@ spec:
projectID:
description: ID of project
type: string
+ x-kubernetes-validations:
+ - message: Immutable field
+ rule: self == oldSelf
topicID:
description: ID of topic
type: string
+ x-kubernetes-validations:
+ - message: Immutable field
+ rule: self == oldSelf
type: object
status:
description: TopicStatus defines the observed state of Topic
|
44smkn
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
Currently, we get the following warning events:
If a subscription is creating before the topic, it fails but will succeed after retrying. It would be nice if we get only the deadline exceeded errors.
How to solve
Notify an error if the deadline is exceeded, i.e.,
Now - CreationTimestamp > Deadline.