Core: Disallow creating hooks outside the current module

Change deprecation warning into an error.

Ref #1576
Closes #1578

Co-authored-by: Ray Cohen <[email protected]>

src/module.js

@@ -77,11 +77,7 @@ function setHookFromEnvironment (hooks, environment, name) {
 function makeSetHook (module, hookName) {
   return function setHook (callback) {
     if (config.currentModule !== module) {
-      Logger.warn('The `' + hookName + '` hook was called inside the wrong module (`' +
-        config.currentModule.name + '`). ' +
-        'Instead, use hooks provided by the callback to the containing module (`' +
-        module.name + '`). ' +
-        'This will become an error in QUnit 3.0.');
+      throw new Error(`Cannot add ${hookName} hooks outside the containing module. Called on "${module.name}", instead of expected "${config.currentModule.name}"`);
     }
     module.hooks[hookName].push(callback);
   };

test/main/modules.js

@@ -419,4 +419,39 @@ QUnit.module('QUnit.module', function () {
       assert.expect(9);
     });
   });
+
+  QUnit.module('improper hook creation', function (hooks) {
+    QUnit.module('child', function (innerHooks) {
+      var outerHookRan = false;
+      var innerHookRan = false;
+      var beforeEachError = null;
+
+      try {
+        hooks.beforeEach(function () {
+          outerHookRan = true;
+        });
+      } catch (e) {
+        beforeEachError = e;
+      }
+
+      innerHooks.beforeEach(function () {
+        innerHookRan = true;
+      });
+
+      QUnit.test('create hook on parent module', function (assert) {
+        assert.deepEqual(beforeEachError, new Error(
+          'Cannot add beforeEach hooks outside the containing module. Called on "QUnit.module > improper hook creation", instead of expected "QUnit.module > improper hook creation > create hook for parent module"',
+          'beforeEachError'
+        ));
+        assert.false(outerHookRan, 'outerHookRan');
+        assert.true(innerHookRan, 'innerHookRan');
+      });
+    });
+
+    QUnit.test('create hook during test', function (assert) {
+      assert.throws(function () {
+        hooks.beforeEach(function () { });
+      }, /Cannot add beforeEach hooks outside the containing module/);
+    });
+  });
 });