[WIP] Core: Connected to #1434: add some method.
#1435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ventuno
commented
Apr 17, 2020
Comment on lines
26
to
+27
| let focused = false; | ||
| let someFocused = false; |
There was a problem hiding this comment.
Alternatively:
const FOCUSED_ONLY = "only";
const FOCUSED_SOME = "some";
const FOCUSED_NONE = "none";
let focused = FOCUSED_NONE;
function isFocused() {
return [FOCUSED_ONLY, FOCUSED_SOME].includes(focused);
}then (when needed) we can simply check focused === FOCUSED_SOME etc...
ventuno
commented
Apr 17, 2020
Comment on lines
+681
to
683
| if ( focused || someFocused ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Alternatively (same below):
if (isFocused()) {
return;
}
ventuno
commented
Apr 17, 2020
Comment on lines
+740
to
+742
| if ( focused ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Alternatively:
if (focused === FOCUSED_ONLY) {
return;
}
ventuno
commented
Apr 17, 2020
Comment on lines
+744
to
+747
| if ( !someFocused ) { | ||
| config.queue.length = 0; | ||
| someFocused = true; | ||
| } |
There was a problem hiding this comment.
Alternatively:
if (focused === FOCUSED_NONE) {
config.queue.length = 0;
focused = FOCUSED_SOME;
}
1 task
|
Closing in favor of: #1436. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP implementation of #1434.
TODO: