Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider removing inst() #2218

Closed
AshesITR opened this issue May 1, 2020 · 0 comments · Fixed by #2260
Closed

Reconsider removing inst() #2218

AshesITR opened this issue May 1, 2020 · 0 comments · Fixed by #2260
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement

Comments

@AshesITR
Copy link

AshesITR commented May 1, 2020

The search from the original issue #1643 shows four packages using devtools::inst() as of now:

  • NlsyLinks, last updated 4 years ago
  • Wats, last updated 5 years ago
  • teachingApps, last updated 2 years ago; no longer using devtools::inst()
  • IalsaSynthesis, last updated 5 years ago

Since the three remaining packages with an actual dependency only have the dependency in their tests and none of them seem to be actively maintained, I would suggest to remove devtools::inst() from the package once again.

The upside of this would be that the auto-complete prefix for devtools::install() shortens to "i" instead of "insta", saving a lot of keystrokes for this very frequent function call.
Also, it's less confusing than to have two functions with very similar name but completely different functionality.

@jimhester jimhester added breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement labels May 1, 2020
hadley added a commit that referenced this issue Jul 30, 2020
jimhester added a commit that referenced this issue Sep 1, 2020
Fixes #2218

Co-authored-by: Jim Hester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants