Always force the promises when loading using load_all #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,11 +94,14 @@ load_all <- function(pkg = ".", reset = TRUE, recompile = FALSE, | |||
| # in the DESCRIPTION file | |||
| pkg$collate <- as.package(pkg$path)$collate | |||
|
|
|||
| # Forcing all of the promises for the loaded namespace now will avoid lazy-load | |||
| # errors when the new package is installed overtop the old one. | |||
There was a problem hiding this comment.
I think it should it be "loaded" instead of "installed"?
There was a problem hiding this comment.
You are correct, this comment was partially copied from install() and I missed that. Fixed with jimhester@1ca9e28 Thanks!
| @@ -94,11 +94,14 @@ load_all <- function(pkg = ".", reset = TRUE, recompile = FALSE, | |||
| # in the DESCRIPTION file | |||
| pkg$collate <- as.package(pkg$path)$collate | |||
|
|
|||
| # Forcing all of the promises for the loaded namespace now will avoid lazy-load | |||
| # errors when the new package is loaded overtop the old one. | |||
| # | |||
| # Reloading devtools is a special case. Normally, objects in the | |||
There was a problem hiding this comment.
I kept that comment because for the devtools case we are forcing the promises to avoid the lazy load errors and because it lets us continue to use the functions when devtools is being reloaded.
But I am fine removing it if it seems confusing.
hadley
added a commit
that referenced
this pull request
Jan 12, 2016
Always force the promises when loading using load_all
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #1001 you can still get lazy load errors if you use
load_all()on a already loaded package for the same reason (promises never forced and then invalided when new code is loaded).This was special cased for devtools so the functions would continue to work, but actually needs to be done for any package that is already loaded to avoid lazy load errors.