Handle repositories specified in Additional_repositories #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Could you please also add a bullet to NEWS? |
|
I am going to add the fix for #943 here as well as they are somewhat related and this pull request will exacerbate the situation there (as users will have more than one repo more often). |
jimhester
force-pushed
the
additional_repositories
branch
from
c58a945 to
e1e40ce
Compare
|
Ok I decided to make them separate after all, this one looks good to merge now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be all that is needed (assuming what is in
Additional_repositoriespoints to a proper 'CRAN-like' repository.An example repository is https://github.com/rOpenGov/bibliographica, which has dependencies
genderandgenderDatafrom ropensci, the rest from CRAN.Fixes #907