Option to turn off helper loading #1169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 41.91%@@ master #1169 diff @@
==========================================
Files 86 86
Lines 4464 4464
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1863 1871 +8
+ Misses 2601 2593 -8
Partials 0 0
|
|
I'd rather not add an argument for this, but instead provide some other way to scope your helpers so they work differently between formal and informal testing. |
| @@ -86,7 +87,7 @@ | |||
| #' } | |||
| #' @export | |||
| load_all <- function(pkg = ".", reset = TRUE, recompile = FALSE, | |||
| export_all = TRUE, quiet = FALSE, create = NA) { | |||
| export_all = TRUE, helpers=TRUE, quiet = FALSE, create = NA) { | |||
There was a problem hiding this comment.
Can you please put spaces around =?
|
On that note, I think it would be great if |
|
@pitakakariki any interest in merging and updating? We'll be working on devtools for the next few weeks. |
|
@hadley will do. Should I wait till devtools is passing on Appveyor or is it okay to do it now? |
|
I've sent a pull request to pkgload here r-lib/pkgload#41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer not to load my testthat helpers with
load_all.I set a bunch of options like default number of simulations and progress bars which need to be different between interactive use and testing.
nb: Relevant issue is #1125