Install Suggested package after package installation #1184
Conversation
This includes packages specified in Remotes:. If build_vignettes is TRUE they are still installed before the package. This fixes tidyverse/dplyr#1809
|
@krlmlr The main issue with this currently is it queries the remotes twice, but getting rate limited seems to be less of an issue with the embedded PAT now. |
| install_deps(pkg, dependencies = dependencies, upgrade = upgrade_dependencies, | ||
|
|
||
| initial_deps <- dependencies[dependencies != "Suggests"] | ||
| final_deps <- dependencies[dependencies == "Suggests"] |
There was a problem hiding this comment.
I think Enhances should be fine to installed in the initial installation. Note Enhances: are not installed unless explicitly set by default (see ?install.packages).
logical indicating whether to also install uninstalled
packages which these packages depend on/link
to/import/suggest (and so on recursively). Not used if
‘repos = NULL’. Can also be a character vector, a subset of
‘c("Depends", "Imports", "LinkingTo", "Suggests",
"Enhances")’Only supported if ‘lib’ is of length one (or missing), so it is
unambiguous where to install the dependent packages. If this is not the case
it is ignored, with a warning.The default, ‘NA’, means ‘c("Depends", "Imports",
"LinkingTo")’.‘TRUE’ means to use ‘c("Depends", "Imports", "LinkingTo",
"Suggests")’ for ‘pkgs’ and ‘c("Depends", "Imports",
"LinkingTo")’ for added dependencies: this installs all the
packages needed to run ‘pkgs’, their examples, tests and
vignettes (if the package author specified them correctly).In all of these, ‘"LinkingTo"’ is omitted for binary
packages.
There was a problem hiding this comment.
What happens if there's a dependency chain like A -> (enhances) B -> (imports) A and I try to install(A) or install_deps(A)?
|
Does this also work for install_deps(".", dependencies = TRUE) for dplyr? |
Yes, that seems to work fine on my machine |
|
I can confirm that dtplyr -> dplyr works (https://travis-ci.org/krlmlr/dplyr/builds/129929004), but not dplyr -> dtplyr -> dplyr if I do install_deps(dependencies = TRUE) (https://travis-ci.org/krlmlr/dplyr/builds/129933568). I think the "release" build always runs with an empty cache because it's failing. |
|
Looks like you forgot to put dtplyr back in |
|
Thanks. Of course I forgot, now it works. My mistake. That's just awesome! Are you planning a release anytime soon? |
This includes packages specified in Remotes:. If build_vignettes is TRUE
they are still installed before the package.
This fixes tidyverse/dplyr#1809