Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revdep check improvements #1284

Merged
merged 21 commits into from
Aug 24, 2016
Merged

Revdep check improvements #1284

merged 21 commits into from
Aug 24, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Aug 2, 2016

  • don't abort if installation of a package fails
  • setup() and create() gain "quiet" argument
  • fully respect "quiet" argument in remote_download.cran_remote()
  • remote_download.cran_remote() explicitly copies file
  • trim whitespace for version in remote_metadata.cran_remote()
  • install_remotes() shows reason for failure
  • list all packages involved in revdep check
  • allow existing but empty check_dir
  • new system2_check() in preparation for Capture installation output and avoid repeated installation attempts for revdep checks #1300
  • cosmetic: on.exit(add = TRUE)
  • package_info() works for nonstandard (e.g., local) repositories
  • rule() fixes
  • update autogenerated test files
  • fix tests
  • print summary table in README.md and problems.md

NEWS entry:

* Various minor improvements around checking of reverse dependencies
  (#1284, @krlmlr). All packages involved are listed at the start,
  the whole process is now more resilient against package
  installation failures.

* Improved handling of local `file://` repositories in `install()` (#1284, @krlmlr).

* `setup()` and `create()` gain new `quiet` argument (#1284, @krlmlr).

* Print summary table in README.md and problems.md (#1284, @krlmlr).

This was referenced Aug 24, 2016
@hadley
Copy link
Member

hadley commented Aug 24, 2016

LGTM

@hadley hadley merged commit 64e6a65 into r-lib:master Aug 24, 2016
@krlmlr krlmlr deleted the f-revdep branch August 25, 2016 20:26
@krlmlr krlmlr restored the f-revdep branch August 26, 2016 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants