Avoid trying to move vignette sources twice #1291
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes multiple vignettes can share source files. This breaks the
file.remove
call which expects unique arguments.the way i encountered this is that
tools::pkgVignettes
has two bugs:tools::loadVignetteBuilder
results in a hardcoding sweave as last engine) and setsengine
to the last one looped (=always sweave)tools:::find_vignette_product
is called with that engine and finds all r scripts in the directory prefixed with that name.this results in duplicated source entries if a vignette’s file name is a prefix of another.