Remove deprecated args argument from install_git()
#1374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please take a look at the build failures? |
Remove the args argument because it is blocking the user from passing args down into the install command
Fix the error message argument "quiet" is missing, with no default by adding quiet with default value FALSE to the install_git function just like it has been done with the install_github function
|
I've taken a look at build failures and resubmitted PR as #1390. There's still a failure on Travis, but seems unrelated. Thanks for taking a look. |
|
@ReportMort You don't need to resubmit, if you push more commits to the same branch the PR was on they will be added to the existing PR. |
|
Thanks @jimhester. I'm aware. This was sort of a dumb thing on my part. I reset hard on some commits and GitHub automatically closed this PR and opened a new one. I closed #1390 and re-opened this guy. |
|
Thanks! Merged in 2636e2a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1373 and also fixes an issue where the
quietargument was explicitly stated intry_install_remote()and throwing error if not explicitly provided upstream.