Match depends correctly #1463
Closed
Match depends correctly #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that only exact matches in imports will get ignored. Currently adding e.g. `plyr` to a package that already imports `dplyr` will silently fail. This will happen for all packages that are substrings of packages already ignored. The proposed change adds regex "fences" around the name of the package to import to circumvent this...
|
The proper way to do this is to use word boundary anchors around the package name. re <- "\\btest\\b"
grepl(re, "test")
#> [1] TRUE
grepl(re, "ttest")
#> [1] FALSE
grepl(re, "testt")
#> [1] FALSE
grepl(re, " test")
#> [1] TRUE
grepl(re, " test ")
#> [1] TRUE
grepl(re, " test, ")
#> [1] TRUE |
|
Oh, didn't know that one... Much cleaner |
|
Thanks! Merged in f7d4c02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that only exact matches in imports will get ignored. Currently adding e.g.
plyrto a package that already importsdplyrwill silently fail. This will happen for all packages that are substrings of packages already ignored.The proposed change adds regex "fences" around the name of the package to import to circumvent this...