-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #394 #439
Fix for #394 #439
Conversation
desc <- file.path(pkg_path, "DESCRIPTION") | ||
|
||
# Remove any blank lines from DESCRIPTION | ||
DESCRIPTION <- readLines(desc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you add warn = FALSE
this also eliminates the need for "Ensure the DESCRIPTION ends with a newline"
Thanks! |
Hi all, apologies if this is not the right way to report this. I've installed Rcompression to solve this problem http://r.789695.n4.nabble.com/Decompressing-raw-vectors-in-memory-td4603202.html via install_github("omegahat/Rcompression"). It seems that the problem reported here also happens here https://github.com/omegahat/Rcompression/blob/master/DESCRIPTION, and I expected, maybe wrongly, this fix to solve it. Or should I remove blank lines from https://github.com/jacopone/Rcompression/blob/master/DESCRIPTION ? Thanks |
I was just able to run That said, removing the trailing spaces as you have is an appropriate workaround if you're still seeing the issue. |
Yes that works well. The problem really happens when in a project using packrat:
Then when I restore() it breaks. The workaround I'm using so far is forking Rcompression, removing the spaces and using that version on my project. Thanks! |
That seems like a fair workaround. Ultimately it seems like the bug would lie in Packrat though, not devtools (it has its own version of |
Hi Hadley,
A simple fix for #394. We read in the
DESCRIPTION
and strip out any blank lines. Not so sure if you want to give a warning though.