Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_coveralls function #681

Merged
merged 9 commits into from
Apr 28, 2015
Merged

use_coveralls function #681

merged 9 commits into from
Apr 28, 2015

Conversation

jimhester
Copy link
Member

This implements the use_coveralls function to add a coveralls test
coverage report to the repository. It also enables a coveralls report
for the devtools repository.

closes #680

I did not include the roxygen results other than NAMESPACE in this pull request to make the diff easier to read.

Let me know if you want anything changed, or if my description is not clear.

You can see examples of repositories with coveralls enabled at

@jimhester
Copy link
Member Author

Sorry, had a few issues with the original pull request, dfdae79 should be good to go though, you will also need to enable the repo at https://coveralls.io/repos/new.

This implements the use_coveralls function to add a coveralls test
coverage report to the repository.  It also enables a coveralls report
for the devtools repository.

closes r-lib#680
@hadley
Copy link
Member

hadley commented Apr 21, 2015

Do you have plans to submit covr to CRAN? Ideally, I'd like to rely only on CRAN packages in the released version

@jimhester
Copy link
Member Author

I am but I am using some devtools functions which are unexported in the current release. (r-lib/covr#63). So ideally I would like to submit covr to CRAN after the next devtools release. Circular dependencies, so we would have to coordinate the releases somehow.

Alternatively I am currently working on extracting the with_* functions, R, RCMD functions from devtools into a new robustr package, along with a couple of utility functions I needed to write for covr. robustr would provide safe alternatives for modifying global state and calling R from within R. Once that is done I can convert covr and devtools to use that package for those functions and that would solve this issue.

If you have other suggestions on functions that you think would be useful to include in robustr I would be happy to include them.

@hadley
Copy link
Member

hadley commented Apr 21, 2015

Ok, that sounds good. In that case, I'm happy to merge this (after some review).

"(https://coveralls.io/r/", gh$username, "/", gh$repo, "?branch=master)"
)

install_loc <- grep("^install:$", travis_content)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit leery about automatically modifying the travis file, especially now that there are two main formats. Could you please just print out instructions? (and update them for the language: r style)

@hadley
Copy link
Member

hadley commented Apr 28, 2015

Bump

Conflicts:
	.travis.yml
	NAMESPACE
	README.md
	man/infrastructure.Rd
	man/use_build_ignore.Rd
	man/use_data.Rd
	man/use_data_raw.Rd
	man/use_git_hook.Rd
	man/use_package.Rd
	man/use_readme_rmd.Rd
@jimhester
Copy link
Member Author

Ok I think everything should be ok with this now, I added a note to the NEWS as well.

@hadley hadley merged commit 5d6a62e into r-lib:master Apr 28, 2015
@hadley
Copy link
Member

hadley commented Apr 28, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coveralls support
2 participants