Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default cache argument for lint #708

Merged
merged 7 commits into from
Apr 21, 2015
Merged

Add default cache argument for lint #708

merged 7 commits into from
Apr 21, 2015

Conversation

jimhester
Copy link
Member

Combined with the bugfix in 2fbfee237c39c47cda15e93e96ef74a16b4bc40d this allows use of the caching functionality in lintr.

Reference timings (lints were previously cached)

system.time(devtools::lint('../../../devtools', cache = FALSE))
#> Linting devtools.....................................................................................................................................
#>    user  system elapsed
#>  85.842   0.660  86.692

system.time(devtools::lint('../../../devtools', cache = TRUE))
#> Linting devtools.....................................................................................................................................
#>    user  system elapsed
#>   3.990   0.139   4.187

@hadley
Copy link
Member

hadley commented Jan 30, 2015

Does this need a bump in the version req for lintr?

@jimhester
Copy link
Member Author

That is a good point, I will update this

@jimhester
Copy link
Member Author

Ok lintr version bumped and requirement added to devtools.

@hadley
Copy link
Member

hadley commented Jan 30, 2015

And would you mind adding a bit more info about the cache? i.e. where it's saved and how to get rid of it. Does the cache file needed to be added to .gitignore and/or .Rbuildignore?

@jimhester
Copy link
Member Author

Ok this should be ok to merge now, let me know if the documentation is unclear.

hadley added a commit that referenced this pull request Apr 21, 2015
Add default cache argument for lint
@hadley hadley merged commit 7a2982f into r-lib:master Apr 21, 2015
@hadley
Copy link
Member

hadley commented Apr 21, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants