Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_testthat adds example test file #758

Closed
wants to merge 2 commits into from
Closed

use_testthat adds example test file #758

wants to merge 2 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 14, 2015

No description provided.

@hadley
Copy link
Member

hadley commented Apr 21, 2015

Motivation?

@krlmlr
Copy link
Member Author

krlmlr commented Apr 21, 2015

  • Example file that can be extended without having to look up testthat syntax
  • R CMD check doesn't start failing

@hadley
Copy link
Member

hadley commented Apr 21, 2015

From my perspective, it's just a file that I always have to remember to delete. That's why create() no longer makes a package doc template.

@krlmlr
Copy link
Member Author

krlmlr commented Apr 21, 2015

How about

use_test <- function(name, pkg = ".")

similar to use_vignette?

@hadley
Copy link
Member

hadley commented Apr 21, 2015

I like it! I'll close this PR since I don't think there will be much overlap.

@hadley hadley closed this Apr 21, 2015
@krlmlr krlmlr mentioned this pull request Apr 22, 2015
Merged
@krlmlr krlmlr deleted the testthat-example branch October 6, 2016 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley