Use with_makevars instead of with_env for with_debug #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously with_debug would not actually change the compilation flags because the variables were set in the environment rather than in a Makevars file. This change adds a `with_makevars` function which sets the compilation flags in a temporary Makevars file.
hadley
added a commit
that referenced
this pull request
Jun 19, 2015
Use with_makevars instead of with_env for with_debug
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously with_debug would not actually change the compilation flags
because the variables were set in the environment rather than in a
Makevars file. This change adds a
with_makevarsfunction which setsthe compilation flags in a temporary Makevars file.
A simple test to see if the previous and new behavior is to look at the compilation flags used when installing devtools.
# in devtools directory clean_dll() with_debug(install())In the current master the compilation flags will be the defaults, including
-O3.Using this pull the flags will be correctly set to the debug flags.