Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use_coverage() function #822

Merged
merged 1 commit into from
May 29, 2015
Merged

Add use_coverage() function #822

merged 1 commit into from
May 29, 2015

Conversation

jimhester
Copy link
Member

To add codecov.io or coveralls.io to a project, also deprecate
use_coveralls().

Closes #818

@hadley
Copy link
Member

hadley commented May 29, 2015

Looks good, but can you merge/rebase please?

@jimhester
Add use_coverage() function
0840e0b 
To add codecov.io or coveralls.io to a project, also deprecate
`use_coveralls()`.

Closes r-lib#818
@jimhester
Copy link
Member Author

Rebased to 2cca68d

hadley added a commit that referenced this pull request May 29, 2015
@hadley
Merge pull request #822 from jimhester/use_coverage
7d12dd8 
Add `use_coverage()` function
@hadley hadley merged commit 7d12dd8 into r-lib:master May 29, 2015
@hadley
Copy link
Member

hadley commented May 29, 2015

Thanks!

@krlmlr
Copy link
Member

krlmlr commented Jun 2, 2015

I think the warnings in R CMD check relate to this pull request:

Undocumented arguments in documentation object 'use_coveralls'
  ‘pkg’

Undocumented arguments in documentation object 'infrastructure'
  ‘type’

They disappear if I revert 0840e0b.

jimhester added a commit to jimhester/devtools that referenced this pull request Jun 2, 2015
@jimhester
Properly document all arguments
9ca8d3b 
- use_coveralls
- use_coverage

Fixes issue pointed out by @krlmlr at r-lib#822
@jimhester jimhester mentioned this pull request Jun 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from coveralls to codecov
3 participants
@jimhester @hadley @krlmlr