Improve rtools registry path detection #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First search for the key in HKCU before attempting HKLM in case the user installed Rtools while on a non-admin account.
|
cc @jjallaire |
|
Thanks! I just made the same change: rstudio/rstudio@be6ba09 One difference is that I scan HKLM first so that the detected version won't change from under existing users (i.e. we'll always do exactly what we did before and then only if we fail entirely will we scan HKCU). |
hadley
added a commit
that referenced
this pull request
Jun 19, 2015
Improve rtools registry path detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First search for the key in HKCU before attempting HKLM in case the user installed Rtools while on a non-admin account.