Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BiocInstaller repositories if installing a Bioconductor package #895

Merged
merged 2 commits into from
Sep 2, 2015

Conversation

jimhester
Copy link
Member

If the user specified repositories take precedence over the default
Bioconductor repositories.

This allows one to use install_github() with Bioconductor packages and have the dependencies work like any other package. e.g.

install_github("Bioconductor-mirror/S4Vectors")

If the user specified repositories take precedence over the default
Bioconductor repositories.
@PeteHaitch
Copy link

Very happy to see this being worked on! (And sorry I haven't made any progress myself)

One question, Jim: are you proposing that dependencies that are from the Bioconductor devel branch are installed from the Bioconductor-mirror github repo rather than using BiocInstaller::useDevel(TRUE); BiocInstaller::biocLite("pkg")? The issue I see there is that those packages available from the Bioconductor-mirror repo aren't guaranteed to pass R CMD build/check since they haven't been run through the BioC build system. Apologies if I've misunderstood.

@jimhester
Copy link
Member Author

@PeteHaitch The dependencies work with this patch the same way they do with biocLite(), they pull from the BiocInstaller::biocinstallRepos(), so it will only be packages that have successfully passed through the Bioconductor build system, not from the git mirrors.

@PeteHaitch
Copy link

Awesome! I thought so (given the code) but your example confused me. Cheers.

@hadley
Copy link
Member

hadley commented Sep 2, 2015

Could you please add a bullet to NEWS?

@jimhester
Copy link
Member Author

Done 406f3dd

hadley added a commit that referenced this pull request Sep 2, 2015
Use BiocInstaller repositories if installing a Bioconductor package
@hadley hadley merged commit ecf945a into r-lib:master Sep 2, 2015
@hadley
Copy link
Member

hadley commented Sep 2, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants