Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more verbose about which package is installed for revdep check #926

Merged
merged 2 commits into from
Jan 13, 2016
Merged

Be more verbose about which package is installed for revdep check #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c0f730
be more verbose about which package is installed for revdep check
Sep 14, 2015
1251f44
NEWS
Jan 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# devtools 1.9.1.9000

* Be more verbose about which package is installed for revdep check
(#926, @krlmlr).

* 'Check failed:' now includes the package name for when Ncpus>1 so you
know which package has failed and can start looking at the output without
needing to wait for all packages to finish (@mattdowle).
Expand Down
2 changes: 1 addition & 1 deletion R/revdep.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ revdep_check <- function(pkg = ".", recursive = FALSE, ignore = NULL,
if (!file.exists(srcpath))
dir.create(srcpath)

message("Installing ", pkg$package)
message("Installing ", pkg$package, " in version ", pkg$version, " from ", pkg$path)
withr::with_libpaths(libpath, install(pkg, reload = FALSE, quiet = TRUE))
on.exit(remove.packages(pkg$package, libpath), add = TRUE)

Expand Down