Degrade gracefully if summary cannot be retrieved for one of the checked packages #929

krlmlr · 2015-09-16T10:07:46Z

example: if the DESCRIPTION file in one of the checked packages is missing

hadley · 2016-01-12T22:07:29Z

R/revdep-summarise.R

@@ -63,6 +65,14 @@ revdep_check_summary <- function(res) {
  )
 }

+try_check_summary_package <- function(path) {
+  res <- try(check_summary_package(path), silent = TRUE)


Can you please use tryCatch() instead? I don't like the way try() works

…ked packages - example: if the DESCRIPTION file in one of the checked packages is missing

hadley · 2016-01-20T16:50:46Z

Thanks!

hadley reviewed Jan 12, 2016
View reviewed changes

Kirill Müller added 4 commits January 13, 2016 09:31

Degrade gracefully if summary cannot be retrieved for one of the chec…

ed7168d

…ked packages - example: if the DESCRIPTION file in one of the checked packages is missing

also don't stop on DESCRIPTION-related error in revdep_check_save_logs

fdbee9f

using tryCatch() instead of try()

513a474

NEWS

50c5993

hadley merged commit 50c5993 into r-lib:master Jan 20, 2016

krlmlr deleted the revdep-no-description branch January 21, 2016 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Degrade gracefully if summary cannot be retrieved for one of the checked packages #929

Degrade gracefully if summary cannot be retrieved for one of the checked packages #929

krlmlr commented Sep 16, 2015

hadley Jan 12, 2016

hadley commented Jan 20, 2016

Degrade gracefully if summary cannot be retrieved for one of the checked packages #929

Degrade gracefully if summary cannot be retrieved for one of the checked packages #929

Conversation

krlmlr commented Sep 16, 2015

hadley Jan 12, 2016

Choose a reason for hiding this comment

hadley commented Jan 20, 2016