revdep_check verifies integrity of already downloaded package files #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please merge/rebase? |
|
Rebased. |
| } | ||
|
|
||
| is_source_pkg <- function(path, subdir = NULL) { | ||
| res <- try(source_pkg_info(path = path, subdir = subdir), silent = TRUE) |
There was a problem hiding this comment.
Could you eliminate use of try() here please?
added 3 commits
January 21, 2016 08:22
|
Rebased, now using tryCatch() instead of try(). |
| tryCatch({ | ||
| source_pkg_info(path = path, subdir = subdir) | ||
| TRUE | ||
| }, error = function(e) return(FALSE)) |
There was a problem hiding this comment.
Don't need explicit return here, but it's not a blocker.
hadley
added a commit
that referenced
this pull request
Jan 21, 2016
revdep_check verifies integrity of already downloaded package files
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid surprises