use_data() improvements #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
krlmlr
commented
Oct 9, 2015
krlmlr
commented
- Helper functions
- Unified code for data and sysdata
- Warn if duplicated objects
- Stop if no objects to save
added 6 commits
October 9, 2015 22:28
- rename get_paths_for_objs() to get_save_info_for_objs() - also return dir_name
| @@ -399,40 +399,75 @@ use_data <- function(..., pkg = ".", internal = FALSE, overwrite = FALSE, | |||
| pkg <- as.package(pkg) | |||
|
|
|||
| to_save <- dots(...) | |||
There was a problem hiding this comment.
Doesn't seem worth it to me - use_data() is purely for interactive use.
| is_name <- vapply(to_save, is.symbol, logical(1)) | ||
| if (any(!is_name)) { | ||
| stop("Can only save existing named objects", call. = FALSE) | ||
| } | ||
| } | ||
|
|
||
| get_objs_from_to_save <- function(to_save) { |
There was a problem hiding this comment.
How about integrating this with check_to_save()?
added 4 commits
January 21, 2016 08:40
|
Inlined functions, merged master, added NEWS. I'd rather not rebase, because I have other internal branches based on this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.