Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release() and build_win() use --compact-vignettes=both #981

Closed
wants to merge 4 commits into from
Closed

release() and build_win() use --compact-vignettes=both #981

wants to merge 4 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 16, 2015

to avoid WARNINGs with the built package.

Kirill Müller added 2 commits November 17, 2015 00:12
@hadley
Copy link
Member

hadley commented Jan 12, 2016

I've never seen these notes. Can you provide more details? What system requirements are necessary to be able to compact vignettes?

@krlmlr
Copy link
Member Author

krlmlr commented Jan 13, 2016

It's even a warning, and happens with PDF vignettes.

http://win-builder.r-project.org/48l69H500MSZ/00check.log was created with 3835a87 and contains:

* checking sizes of PDF files under 'inst/doc' ... WARNING
  'gs+qpdf' made some significant size reductions:
     compacted 'tikzDevice.pdf' from 1137Kb to 493Kb

@hadley
Copy link
Member

hadley commented Jan 13, 2016

Hmmm, if it needs other software, we definitely shouldn't do this unconditionally. Could you please add a check for the presence of the needed software?

@krlmlr
Copy link
Member Author

krlmlr commented Jan 13, 2016

Didn't think about that. Adding an args argument to release() would be simpler and potentially more useful, would you prefer that? (build_win() already has one.)

@hadley
Copy link
Member

hadley commented Jan 13, 2016

Yeah, that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants