Support passthrough of credentials to git2r #982
Conversation
|
AppVeyor test is failing because it's hitting the Github API Rate limit while running the tests. |
| @@ -18,20 +20,21 @@ | |||
| #' install_git("git://github.com/hadley/stringr.git") | |||
| #' install_git("git://github.com/hadley/stringr.git", branch = "stringr-0.2") | |||
| #'} | |||
| install_git <- function(url, subdir = NULL, branch = NULL, args = character(0), | |||
| install_git <- function(url, subdir = NULL, branch = NULL, credentials=NULL, args = character(0), | |||
There was a problem hiding this comment.
Please put spaces around = to match existing style
There was a problem hiding this comment.
@hadley would you like same thing done for use_github()?
… install_remote has FALSE for that argument, and short circuit so install is only called once
…o other temp directories and fix the missing bracket in test
…eck for clean directory
…e DESC file updated the test expectation to match what actually gets returned
…ll as better handling lack of sha1 and or user / remote
…ctions separate so that can make independent changes if needed later
…they should just give the same metadata, and no reason to be separate functions
…wo if statements instead of an if else if
…he setting to NULL in else statements to make it a little clearer
|
If you can do this by Friday it'll make it in 1.10, otherwise it will have to wait for 1.11 (probably in about a months time) |
…to rmflight-install_sha
…version of the package, and add a test using load_all() followed by install as this was causing a failure previously
…operly and without any errors
…emote-metadata testing
…gument and the change in behavior.
|
Also added the credentials passthrough to use_github as suggested. I checked for other git2r clone/push/fetch but missed that one. This could probably have been 1 or 2 commits - will chalk that down to experience. |
|
@onlymee you can squash your commits with You should also rebase this PR against the current master first which would remove a lot of the above commits. If you have 'hadley/devtools' as the remote called |
|
Can you please rebase & squash? |
git2r has very sensible defaults for credentials, eg. for ssh it defaults to looking for ssh-agent, but there are times where it is useful to specify specific credentials.
This modification simply allows for a git2r credentials object to passet through to the underlying clone call. This is useful if you wish to use devtools non-interactively (e.g. a script in a CI solution)