Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libpath arg during build #196

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

use libpath arg during build #196

wants to merge 5 commits into from

Conversation

pawelru
Copy link

@pawelru pawelru commented Feb 15, 2023

closes #195

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #196 (cbcee23) into main (b82f540) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head cbcee23 differs from pull request most recent head e4aeee7. Consider uploading reports for the commit e4aeee7 to get more accurate results

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   80.83%   80.63%   -0.20%     
==========================================
  Files          19       19              
  Lines        1007     1007              
==========================================
- Hits          814      812       -2     
- Misses        193      195       +2     
Impacted Files Coverage Δ
R/build.R 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pawelru
Copy link
Author

pawelru commented Mar 30, 2023

Hi @gaborcsardi can you please have a look? I think it's a quick fix out there. Not sure if you like the test case though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libpath argument is not respected during build step
2 participants