Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix editSVG to work with new inlineSVG/svgstring #56

Closed
timelyportfolio opened this issue Feb 9, 2016 · 1 comment
Closed

fix editSVG to work with new inlineSVG/svgstring #56

timelyportfolio opened this issue Feb 9, 2016 · 1 comment

Comments

@timelyportfolio
Copy link
Contributor

In a370b05, inlineSVG we changed to use svgstring instead of svglite. However, the path argument still exists even though it is no longer used.

Also, editSVG will no longer work since it requires a saved file. Add the expected-to-be-removed-from-inlineSVG path argument to editSVG.
timelyportfolio referenced this issue Feb 9, 2016
@hadley
Use svgstring() for inlineSVG().
a370b05 
cc @timelyportfolio
@timelyportfolio
Copy link
Contributor Author

I will submit a pull shortly.

timelyportfolio added a commit to timelyportfolio/svglite that referenced this issue Feb 9, 2016
@timelyportfolio
address r-lib#56 by removing path argument from inlineSVG and add…
3b5ddfb 
…ing `path` argument to `editSVG`
@timelyportfolio timelyportfolio mentioned this issue Feb 9, 2016
Closed
@timelyportfolio timelyportfolio mentioned this issue Jul 27, 2016
Closed
@hadley hadley closed this as completed in 8bc1980 Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removes path argument from inlineSVG and adds path to editSVG timelyportfolio/svglite
1 participant
@timelyportfolio