The checks for NA_INTEGER are unnecessary. The value of NA_INTEGER is… #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a valid colour (#80). NA values for colour have already been converted to completely transparent white (#ffffff00) before reaching svglite.
See
R_ext/GraphicsDevice.h
where it says:So a check for
NA_INTEGER
on a colour is meaningless since it will match a different colour (#80)