Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of superseded lifecycle badge to blue. #1808

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

batpigandme
Copy link
Contributor

Erroneously had it as orange in #1663.

@jennybc
Copy link
Member

jennybc commented Mar 16, 2023

I've made a second change here. Just in case we do more badge updates in the future I want to point this out. The SVGs here:

man/figures

are what usethis uses as a normal R package.

The SVGs here:

inst/templates

are what usethis places in other packages (or even itself) when their maintainer calls use_lifecycle().

So typically if you're making a badge update the second location is even more important than the first.

A good workflow is probably to make any necessary updates to inst/templates/lifecycle-*.svg, do load_all(), and then use_lifecycle() to see if man/figures/lifecycle-*.svg gets the intended updates.

Sidebar: the snapshot test failure is unrelated to this PR which I'm about to merge.

@jennybc jennybc merged commit 8b833e8 into r-lib:main Mar 16, 2023
@batpigandme batpigandme deleted the superseded-badge-fix branch March 20, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants