Update getState to return an array, which could be extracted like react useState. #14
Assignees
Labels
Comments
rabisnaqvi
added
enhancement
|
Hey rabisnaqvi, I changed the getState function to how you mentioned above. How can I create a pull request? |
|
Are you able to give me write access? Or should I fork the repo, make the changes then submit a PR that way? |
|
Hey @Siar416 , thanks for contributing to this! you can create a branch from the issue, and then generate a PR to merge into the "release-candidate" branch. you can try that, if you face any permission issues then let me know I'll get that sorted. |
|
Thanks for the fast response. I forked the repo and created a branch. Made the changes and submitted a PR from my forked branch to the release-candidate branch. Sent from my iPhoneOn May 24, 2023, at 2:19 PM, Rabis Naqvi ***@***.***> wrote:
Hey @Siar416 , thanks for contributing to this! you can create a branch from the issue, and then generate a PR to merge into the "release-candidate" branch. you can try that, if you face any permission issues then let me know I'll get that sorted.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Merged
rabisnaqvi
pushed a commit
that referenced
this issue
May 25, 2023
…ct useState.#14 Updated unit tests to match the updated response from Astral.context.getState.
rabisnaqvi
added a commit
that referenced
this issue
May 25, 2023
…eact usestate (#21) 🤯 Update getState to return an array, which could be extracted like react useState.#14 * Updated the getState function to return an array similiar to how useState hook works * Minor adjustment, instead of passing setState we are now passing a lister function instead. * Update getState to return an array, which could be extracted like react useState.#14 * Updated unit tests to match the updated response from Astral.context.getState. --------- Co-authored-by: Siar <[email protected]> Co-authored-by: Rabis Naqvi <[email protected]>
rabisnaqvi
moved this from Done
to Awaiting Release
in Astral.js Main Development Board
github-project-automation
bot
moved this from Awaiting Release
to Done
in Astral.js Main Development Board
rabisnaqvi
moved this from Done
to Awaiting Release
in Astral.js Main Development Board
Merged
rabisnaqvi
added a commit
that referenced
this issue
May 26, 2023
- 🤯 Updated the getState function to return an array (tuple) similar to how React's useState hook works (#14 ) - ✅ Updated unit tests to match the updated response from Astral.context.getState. - 📃 Fix broken hyperlink in the Getting Started section (#26 ) - Replaced the broken hyperlink reference with the correct anchor link to the "Core Concepts" section. - Ensured that the anchor link matches the heading in the "Core Concepts" section. - 🌀 Integrate Typescript or babel (#15 ) - Converted all the source files to TypeScript namespaces. - Updated build process to parse the javascript files. - Replaced JSDOC with TypeDoc to generate documentation for the new typescript codebase. - Updated ESLINT configuration to be integrated with TypeScript. - Added some unit tests. - 📃Break features and definitions into different lines in readme (#24 ) - Updated readme.md to fix the line breaks and to reflect new updated features in Astral.context.getState and Astral.context.updateState. - 📃Updated CONTRIBUTING.md - Updated CONTRIBUTING.md to ensure updated contributing processes. --------- Co-authored-by: Rabis Naqvi <[email protected]> Co-authored-by: Siar <[email protected]> Co-authored-by: HARSH SRIVASTAV <[email protected]>
rabisnaqvi
moved this from Awaiting Release
to Done
in Astral.js Main Development Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update getState to return an array, which could be extracted like react useState.
so it would be something like this:
const [count, onCountChange] = Astral.context.getState('count');The text was updated successfully, but these errors were encountered: