fix: Running with no auth module will ignore assert access rule

[dhedey]

Summary

A small fix for Dugong which has been noted a few times in the community now.

Previously if someone runs a preview with the no_auth flag, then anything using assert_access_rule will still break the transaction. As of Dugong, assert_access_rule will be a no-op if the no_auth flag is set.

Testing

Added new tests to test the before/after behaviour

Changelog

Entry added.

[github-actions]

Docker tags
docker.io/radixdlt/private-scrypto-builder:2589208c9a

[github-actions]

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:2589208c9a

[github-actions]

Benchmark for 2589208

Click to view benchmark

Test	Base	PR	%
costing::bench_prepare_wasm	44.8±0.21ms	44.8±0.26ms	0.00%
costing::decode_encoded_i8_array_to_manifest_raw_value	19.4±0.14ms	19.7±0.08ms	+1.55%
costing::decode_encoded_i8_array_to_manifest_value	41.4±0.08ms	41.5±0.07ms	+0.24%
costing::decode_encoded_tuple_array_to_manifest_raw_value	70.8±0.17ms	71.4±0.16ms	+0.85%
costing::decode_encoded_tuple_array_to_manifest_value	98.6±0.21ms	105.6±0.21ms	+7.10%
costing::decode_encoded_u8_array_to_manifest_raw_value	26.0±0.14µs	32.2±0.16µs	+23.85%
costing::decode_encoded_u8_array_to_manifest_value	41.3±0.07ms	41.3±0.11ms	0.00%
costing::decode_rpd_to_manifest_raw_value	14.6±0.05µs	14.6±0.05µs	0.00%
costing::decode_rpd_to_manifest_value	11.3±0.07µs	10.9±0.03µs	-3.54%
costing::deserialize_wasm	1220.9±3.84µs	1213.5±4.44µs	-0.61%
costing::execute_transaction_creating_big_vec_substates	694.5±9.30ms	691.7±8.23ms	-0.40%
costing::execute_transaction_reading_big_vec_substates	589.9±1.00ms	593.7±1.40ms	+0.64%
costing::instantiate_flash_loan	1101.0±1843.73µs	952.4±769.47µs	-13.50%
costing::instantiate_radiswap	969.7±1058.06µs	980.4±799.93µs	+1.10%
costing::scrypto_malloc	692.6±1.23ms	668.9±1.21ms	-3.42%
costing::scrypto_sbor_decode	683.7±1.97ms	667.2±2.51ms	-2.41%
costing::scrypto_sha256	598.3±1.15ms	593.3±0.94ms	-0.84%
costing::spin_loop_v1	538.7±1.29ms	512.2±4.57ms	-4.92%
costing::spin_loop_v2	596.2±0.48ms	612.5±5.00ms	+2.73%
costing::validate_sbor_payload	29.2±0.11µs	29.5±0.08µs	+1.03%
costing::validate_sbor_payload_bytes	247.7±0.73ns	246.3±0.74ns	-0.57%
costing::validate_secp256k1	76.7±0.09µs	76.8±0.31µs	+0.13%
costing::validate_wasm	33.7±0.09ms	33.5±0.07ms	-0.59%
decimal::add/0	8.4±0.02ns	8.4±0.01ns	0.00%
decimal::add/rust-native	9.8±0.02ns	9.9±0.02ns	+1.02%
decimal::add/wasmi	310.8±4.86ns	316.2±2.91ns	+1.74%
decimal::add/wasmi-call-native	3.0±0.00µs	3.0±0.01µs	0.00%
decimal::div/0	169.1±0.17ns	167.9±0.22ns	-0.71%
decimal::from_string/0	155.8±0.47ns	156.2±0.40ns	+0.26%
decimal::mul/0	129.1±0.29ns	127.8±0.27ns	-1.01%
decimal::mul/rust-native	127.5±0.17ns	125.6±0.29ns	-1.49%
decimal::mul/wasmi	19.2±0.07µs	19.3±0.07µs	+0.52%
decimal::mul/wasmi-call-native	3.1±0.01µs	3.1±0.00µs	0.00%
decimal::pow/0	593.8±1.25ns	596.0±0.66ns	+0.37%
decimal::pow/rust-native	587.3±0.81ns	588.7±1.09ns	+0.24%
decimal::pow/wasmi	91.3±0.73µs	91.9±0.36µs	+0.66%
decimal::pow/wasmi-call-native	4.9±0.01µs	4.8±0.01µs	-2.04%
decimal::root/0	8.1±0.02µs	8.1±0.01µs	0.00%
decimal::sub/0	8.2±0.01ns	8.1±0.01ns	-1.22%
decimal::to_string/0	437.9±0.35ns	440.2±0.55ns	+0.53%
large_transaction_processing::prepare	2.4±0.01ms	2.4±0.00ms	0.00%
large_transaction_processing::prepare_and_decompile	6.1±0.05ms	6.2±0.04ms	+1.64%
large_transaction_processing::prepare_and_decompile_and_recompile	25.5±1.50ms	32.0±0.19ms	+25.49%
metadata_validation::validate_urls	4.9±0.08µs	4.8±0.05µs	-2.04%
precise_decimal::add/0	8.9±0.07ns	8.9±0.08ns	0.00%
precise_decimal::add/rust-native	10.9±0.08ns	10.9±0.06ns	0.00%
precise_decimal::add/wasmi	426.8±3.93ns	431.5±2.65ns	+1.10%
precise_decimal::add/wasmi-call-native	3.8±0.00µs	3.8±0.01µs	0.00%
precise_decimal::div/0	289.4±2.49ns	291.3±0.59ns	+0.66%
precise_decimal::from_string/0	204.6±0.31ns	202.5±0.25ns	-1.03%
precise_decimal::mul/0	331.4±1.09ns	333.2±0.62ns	+0.54%
precise_decimal::mul/rust-native	297.0±1.23ns	287.9±0.58ns	-3.06%
precise_decimal::mul/wasmi	47.8±0.07µs	49.0±0.12µs	+2.51%
precise_decimal::mul/wasmi-call-native	4.2±0.00µs	4.2±0.01µs	0.00%
precise_decimal::pow/0	1740.4±5.38ns	1724.6±1.92ns	-0.91%
precise_decimal::pow/rust-native	1367.4±1.33ns	1368.7±4.17ns	+0.10%
precise_decimal::pow/wasmi	231.9±0.70µs	233.4±1.15µs	+0.65%
precise_decimal::pow/wasmi-call-native	7.6±0.01µs	7.7±0.04µs	+1.32%
precise_decimal::root/0	58.3±0.07µs	58.4±0.11µs	+0.17%
precise_decimal::sub/0	9.1±0.16ns	9.0±0.07ns	-1.10%
precise_decimal::to_string/0	697.9±1.90ns	696.8±3.07ns	-0.16%
schema::validate_payload	390.7±0.77µs	384.9±0.60µs	-1.48%
transaction::radiswap	5.1±0.03ms	5.0±0.03ms	-1.96%
transaction::transfer	1813.9±7.13µs	1813.0±5.55µs	-0.05%
transaction_validation::validate_manifest	43.2±0.15µs	43.3±0.13µs	+0.23%
transaction_validation::verify_bls_2KB	1065.7±22.35µs	1005.2±12.61µs	-5.68%
transaction_validation::verify_bls_32B	1004.9±8.68µs	1035.1±28.78µs	+3.01%
transaction_validation::verify_ecdsa	74.7±0.16µs	74.7±0.19µs	0.00%
transaction_validation::verify_ed25519	50.6±0.22µs	42.3±0.14µs	-16.40%