fallback to package.json when stdin closed with no content #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raineorshine
requested changes
Feb 16, 2017
test/test-ncu.js
Outdated
| it('should fall back to package.json search when receiving empty content on stdin', function (done) { | ||
| var childProcess = child.exec('node bin/ncu', function (error, stdout) { | ||
| if (error) { | ||
| throw new Error(error); |
There was a problem hiding this comment.
Throwing an error in a callback will not necessarily bubble up. You should call done(error) instead to explicitly fail the test.
lib/npm-check-updates.js
Outdated
| programError(chalk.red(relPathToPackage + ' not found')); | ||
| } | ||
| return pkgData.then(function (_pkgData) { | ||
| print('wtf', _pkgData); |
|
Whoops! That def shouldn't have made it through :) |
ghost
closed this
ghost
reopened this
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making this change to with #119
The change is to support a parent process starting ncu with child_process, closing stdin without piping package.json content and having ncu fallback to search for package.json from fs.