Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1061] Dynamic Meta Description for Sub Pages #1062

Merged
merged 9 commits into from
Aug 12, 2019

Conversation

jinojossy93
Copy link

Issue Reference

This PR addresses the Issue : Fixes #

Hard coded sub page description for Important Announcements Page

Summarize

Please, describe what the PR does, the changes you have made.

I have added new block in base.html and overrided it in announcement.html.

Also, mention the key points if any to look into while code reviews

The description I could find for this page is "Important Announcements regarding Kerala Rescue Operations".

Please suggest something better if somebody has a better suggestion.

@subins2000
Copy link

subins2000 commented Aug 11, 2019

@jinojossy93 Can ya modify this to include per announcement description please ? #1054 has been merged which gives a permalink for each announcement. It would be great if title & description of each announcement page is unique so that the link previews in whatsapp/social media stands out.

Also try to change <meta name="Description"> too

@jinojossy93
Copy link
Author

@subins2000 lemme check the latest changes.
I'll start work on that soon.

@qburst-jino
Copy link

@subins2000
Completed the requested changes. Please have a look

@subins2000
Copy link

Tested this. It works good. By having descriptions, the link preview in whatsapp/social media for individual announcements will be better.

@biswaz @vigneshhari @tomahawk-pilot

@jinojossy93
Copy link
Author

@biswaz @vigneshhari @tomahawk-pilot @subins2000

I missed to correct the default description for announcement page. Completed the same now.

@subins2000
Copy link

much better

@biswaz biswaz merged commit 64d1f99 into raksha-life:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants