-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle Modal: Basic Implementation #8726
Conversation
581a3de
to
ff7ac20
Compare
@scures There's some test failures, can you take a look? Is it ready to come out of draft as well? |
@richard-cox those tests look odd, I'll check them, it might be related with the comment of updating to 2.7 (which I already rebased). |
You have 1 typo in the description, it's not |
@scures no you still have to rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have encountered 3 issues while testing the functionality:
- The homepage has no inactivity, beside we have the component in the layout
- In the first occurrence only, the countdown does start
- After refreshing the page the whole logic stops working
Kapture.2023-04-28.at.11.52.45.mp4
Beside this, I wonder if we should not expose the inactivity status to Vuex, as other logic and components may profit from this. For instance we may avoid to use this component to start/stop subscription at a certain point and maybe wrapping the whole in a single action.
PS: There's some concerns related to the modal which have been added in #8207 as we do not want to tackle them here.
Given #8775, can this one now be closed? |
@richard-cox I wasn't sure if we want to keep the 2 PR's since we have the two issues. But if linking the two issues to 1 PR it's fine, lets do it =) |
@scures You have to add the extra fix to the other PR and close this with a comment. |
Closing this PR for its continuity in #8775 |
NOTE: This feature was split in 2 parts; while waiting for feedback I made a branch from this one and start working on the second part of it #8775 which will glue everything together + fixed/refactored most of the code in this initial PR; The review/testing focus should go into #8775
Summary
Fixes #8321
Technical notes summary
Added a new
<Inactivity />
componentAreas or cases that should be tested
/shell/layouts/default.vue#L770
change it to enable like this<Inactivity enabled />
/shell/components/Inactivity.vue
they're some props you can play around like after how much time the initial modal will show and how much time does the user have until we unsubscribe from theWS
.Resume Session
button and it will reset the inactive timer. Moving the mouse, pressing keys etc.. should keep reseting the timer, the moment you stop those actions, it will start counting down and aftershowModalAfter
it will show the countdown.rancher
,manager
and,cluster
Screenshot/Video