Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Feature request: Firefox support #1150

Closed
miltador opened this issue May 31, 2017 · 24 comments
Closed

Feature request: Firefox support #1150

miltador opened this issue May 31, 2017 · 24 comments

Comments

@miltador
Copy link

miltador commented May 31, 2017

It would be awesome to see this extension for Firefox browser. As Firefox supports WebExtensions API, I believe it won't be difficult to make it working on Firefox. I saw React Dev Tools extension on Firefox, Angular community is now missing this one for Firefox.

@captainbrosset
Copy link

Firefox now supports a wide range of WebExtension APIs, including DevTools-related APIs. This means that without changing much of the extension's code, it should just work on Firefox.

I tried running it in Firefox and got this:

capture

Not bad for a first test, at least the panel appears and has some content.
There's an error in the console though: Augury initialization has failed <unavailable> content-script.js:5711.

Looking into it more, the <unavailable> bit is actually Error: Could not establish connection. Receiving end does not exist.

CC @clarkbw who has been working recently on helping other extensions like react, redux, ember, vuejs become fully Firefox compatible. Maybe he can help here too.

@clarkbw
Copy link

clarkbw commented Jun 7, 2017

I'm seeing some intermittent issues here and I don't know Angular well enough to be able to traverse the code. It seems to drop the connection at times and others it works. I can pair with someone to get them through the Firefox parts but I'll need help with the rest.

@igor-ka
Copy link

igor-ka commented Jun 7, 2017

Hey @captainbrosset and @clarkbw we will be happy with that. We are thinking of a potential refactor to support different shells easier and would appreciate help and/or input on that.

Can we chat over Slack?

@clarkbw
Copy link

clarkbw commented Jun 7, 2017

Can we chat over Slack?

Sounds good! I've joined the Slack as @clarkbw

Lets try to chat soon, ping me when you get a chance @igor-ka

@digitarald
Copy link

Hi @igor-ka , I am taking over this effort from @clarkbw , working with @captainbrosset . To kick things off I joined Slack and will ping you.

@adityamenon
Copy link

adityamenon commented Oct 28, 2017

Hello all, I do not see anything on the README or an Addon on Firefox yet. Which GitHub PR are we tracking the progress for this on?

@karlos1337
Copy link

Something about this?

@Invis1ble
Copy link

bump

@andrewthauer
Copy link
Contributor

Firefox support is definitely on the roadmap. but at this point I couldn't give an exact timeline. As far as I know, there are no open PR's related to Firefox support.

There has been some encouraging initial success getting Augury running in Firefox (debug mode) so hopefully the effort is relatively small.

@santiago-elustondo
Copy link
Contributor

Howdy! Please see progress on this PR: #1268
We hope to be able to release as a FireFox add-on very soon.

@andrewthauer
Copy link
Contributor

We will also need to ensure the following are updated / checked before publishing:

  • Ensure all UI messaging (labels, etc.) are not making specific reference to Chrome
  • Update the README accordingly as well
  • README reference npm scripts which have changed

@callahad
Copy link

Looks like Augury is now live on AMO: https://addons.mozilla.org/en-US/firefox/addon/angular-augury/

🎉

@andrewthauer
Copy link
Contributor

It is indeed. It's currently marked as experimental since it's based on the current dev branch. The official release should come very soon.

@andreicristianpetcu
Copy link
Contributor

@callahad It is not online. I cannot see it both with your link and by searching it :(

@andrewthauer
Copy link
Contributor

The add-on was available for a couple of days, but is now disabled based on some warnings encountered in an add-on review by Mozilla. These will need to be addressed before we can re-submit the add-on.

NOTE: This was just an experimental release (not official), so please be patient while we work through the submission & approval process.

@andreicristianpetcu
Copy link
Contributor

andreicristianpetcu commented Apr 13, 2018

I signed the addon for whoever wants an early beta until it lands in AMO. Happy Hacking

If you want to sign it yourselves please upload a build here and then just add the signed XPI file to the release page of the GH repo.

@andreicristianpetcu
Copy link
Contributor

andreicristianpetcu commented Apr 18, 2018

If you are using my unofficial Firefox build know that it breaks up XML formatting in Firefox :(

Cheer up! I fixed it with a PR and another unofficial build :)

@andrewthauer
Copy link
Contributor

UPDATE: We are in the process of working through some of the issues that were flagged during the AMO review process. Unfortunately, some of these are not completely straight forward to address due to various factors. I'm hopeful we can work through them in a timely matter, but at this point I can't give an ETA on when that might be exactly.

@andreicristianpetcu
Copy link
Contributor

@andrewthauer I know Firefox has higher security/privacy standards and publishing a Chrome extension in addons.mozilla.org takes some time. No rush.

I will keep reporting bugs, sending patches and publishing unofficial Firefox builds for whoever is interested.

@andreicristianpetcu
Copy link
Contributor

I'm having some performance issues with Augury in Firefox :( I reported the issue here. I used https://perf-html.io to record a performance profile for whoever is interested.

@pickfire
Copy link

Augury is now in firefox addons but it keeps appearing in the developer panel even though the webapp is not written in angular.

@santiago-elustondo
Copy link
Contributor

@pickfire, the FireFox add on is still very much in beta, and we are working through various quirks.
That said, the Augury tab should always be present in the dev tools, regardless of whether the app is Angular or not.
The tab should display a message saying that Angular was not detected in the page. If this is not occurring, then you have identified a bug. Please create an issue with a screenshot, and we'll address it.

@pickfire
Copy link

@santiago-elustondo Okay, I didn't expect that it works fine with an unexpected behaviour since both vue and react extension does not show up if the framework is not detected, if so everything would be so cluttered.

@andrewthauer
Copy link
Contributor

Firefox extension has been available for a while now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests