FireFox compatibility using WebExtensions format. #1268

santiago-elustondo · 2018-01-24T18:47:16Z

santiago-elustondo · 2018-01-24T18:49:04Z

todo at this point:

Mozilla add-on verification required. (can currently load .xpi as a temporary add-on)
fix: toolbar popup (container too small, shows a scroll bar)
decision: manifest.require_url is not supported by Mozilla, (giving an error when loading plugin. it does not prevent plugin from loading, however) [CURRENTLY LEFT IN]
- https://wiki.mozilla.org/Apps/ManfiestFormatComparisonReading
decision: manifest.background.persistent is not supported by Mozilla. (we could leave it in place, although mozilla throws error) [CURRENTLY REMOVED]
- https://developer.chrome.com/extensions/event_pages
- https://wiki.mozilla.org/Apps/ManfiestFormatComparisonReading

We could either ignore certain parsing errors on mozilla's end, edit the manifest such that it does not use unsupported features, or create 2 separate manifest files.

andrewthauer · 2018-02-01T14:28:40Z

manifest/firefox.manifest.json

@@ -0,0 +1,44 @@
+{


Instead of maintaing complete manifests for each browser, I’m wondering if having a base template and merging differences per browser might be more maintainable?

This could be done using object literals that get merged together and then saved as the final manifest.json file.

andrewthauer · 2018-02-01T20:35:09Z

package.json

    "build": "webpack --colors --display-error-details --display-cached",
+    "build-chrome": "cross-env BROWSER=chrome npm run build",


I personally like using the namespace:task convention for npm scripts. For instance:

build: '...', build:prod: 'npm run build:prod:chrome && npm run build:firefox', build:prod:firefox: '...', build:prod:chrome: '...'

sumitarora

looks good awesome :D

andrewthauer

@santiago-elustondo - Looks good! Did you still have outstanding manifest questions?

santiago-elustondo · 2018-02-07T14:10:01Z

no outstanding manifest questions

potch · 2018-02-09T21:29:14Z

Hello! I'm Potch, from Mozilla dev advocacy.

I built this branch locally and loaded the extension into Firefox to test it out. It seems to be working, but do you have any specific test apps I can point it at to verify?

Thanks for putting in the leg-work to port!

sumitarora · 2018-02-09T21:55:25Z

@potch You can test any of the Angular 2+ applications. We use this as the base application to check https://github.com/rangle/augury-examples/tree/master/kitchen-sink-demo If you want to check just run the application and test it in Firefox :D

potch · 2018-02-12T23:23:49Z

I wasn't able to get the kitchen-sink-demo to build, but tried it on https://angular-quickstart.glitch.me/ and got the expected panel and was able to browse the (admittedly tiny) component tree. Excited to see this working!

abdulkareemnalband · 2018-03-21T05:46:45Z

What is the status of this PR?

andrewthauer · 2018-03-22T14:48:01Z

We are currently working to get Augury approved in the Firefox add-on store. We hit a small issue with the add-on size which is being investigated. In the short-term you could pull the PR branch, build the add-on, then install the add-on from a file.

digitarald · 2018-03-23T20:24:52Z

@andrewthauer it looks like the referenced AMO issue will not be fixed soon (as not many extensions are known to be blocked by this, so it is hard to make weigh risks vs benefits; working on it). Are you waiting on this or are you still working on splitting/reducing JS bundle size?

andrewthauer · 2018-03-23T21:13:12Z

@digitarald we are good now. We were able to get the bundle size down and I was able to successfully submit the add-on. Just a few final tweaks and it should be ready to go very soon.

Thanks for following up. Looks like the AMO issue can be closed. Anything else you can think of that we should look at or do before publishing?

digitarald · 2018-03-29T17:33:41Z

@andrewthauer looks like you submitted? Did it all work out?

andrewthauer · 2018-03-29T19:56:37Z

@digitarald we did. It was initially approved, then disabled after another AMO review. There are a 4 issues that we will have to work though before re-submitting it looks like. I haven't had a chance to review them in detail so I'm not sure on the scope of change required yet.

digitarald · 2018-03-30T05:29:01Z

Our review process is a little more involved, hopefully it doesn’t cause too much extra work. If anything is unclear, you can ask the reviewers by replying to the review email. Feel free to loop me in as needed.

* fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package)

andrewthauer · 2018-04-12T15:01:10Z

Thanks @digitarald! I've followed up with some additional questions for the reviewer. I'll reach out to you if we run into any problems.

* Release (1.16.0) (#1284) * fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * remove update_url from manifest.json for chrome * Update CHANGELOG (1.16.0) * Release (1.16.0) - Tag Version

* Release (1.16.0) (#1284) * fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * remove update_url from manifest.json for chrome * Update CHANGELOG (1.16.0) * tag version * #1289: set script.textContent only if the document is HTML (Avoids breaking Firefox XML formatter)

* Release (1.16.0) (#1284) * fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * remove update_url from manifest.json for chrome * Update CHANGELOG (1.16.0) * Release (1.16.0) - Tag Version * add build configs accessible from code * explanatory note on types * merge in all build configs * correction * clean up env config * linter * touchups * linter * csp update

* fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * Update dev branch to match master. (#1292) * Release (1.16.0) (#1284) * fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * remove update_url from manifest.json for chrome * Update CHANGELOG (1.16.0) * Release (1.16.0) - Tag Version * Fix firefox xml viewer (#1290) * Release (1.16.0) (#1284) * fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * remove update_url from manifest.json for chrome * Update CHANGELOG (1.16.0) * tag version * #1289: set script.textContent only if the document is HTML (Avoids breaking Firefox XML formatter) * Upgrading to webpack 4 (#1285) * Angular AOT Build (#1295) * Upgrading to webpack 4 * Adding aot compilation support * Removing uncessary imports in aot build * version up for merge-jsons plugin. prev versions crash with Webpack4 * Fixing test and build * local fonts (#1297) * Build conditionals (#1296) * Release (1.16.0) (#1284) * fix bug: frontend doesnt clear error screen when app detected (#1274) * FireFox compatibility using WebExtensions format. (#1268) * modify manifest for compatibility * add web extensions packing * remove augury.xpi * fix popup size in firefox * browser-specific builds * browser-specific builds * manifest.json merging & npm script naming scheme * uncomment sentry_key check * add uglify * add canary to builds * add canary to builds * version up * add yihua fix * linter * version up * Updating docs and text to reflect Firefox support (#1278) * small patch for PrimeNG * linter * version up * fix dependencies thing yet again * version up * include canary build in ISSUE_TEMPLATE.md * Update README.md with canary * remove comma * version up for release (manifest) * version up for release (package) * remove update_url from manifest.json for chrome * Update CHANGELOG (1.16.0) * Release (1.16.0) - Tag Version * add build configs accessible from code * explanatory note on types * merge in all build configs * correction * clean up env config * linter * touchups * linter * csp update * use destructuring import * json5-parsing * version up * linter * fix function-name.ts (state bug) * ready for release * update package-lock.json

santiago-elustondo added 2 commits January 24, 2018 13:09

modify manifest for compatibility

adc249d

add web extensions packing

37b0afc

remove augury.xpi

4c9a21b

santiago-elustondo mentioned this pull request Jan 24, 2018

Feature request: Firefox support #1150

Closed

sumitarora self-assigned this Jan 24, 2018

santiago-elustondo requested a review from sumitarora January 24, 2018 19:43

santiago-elustondo self-assigned this Jan 24, 2018

santiago-elustondo added 3 commits January 26, 2018 12:40

fix popup size in firefox

c09ad0e

browser-specific builds

16ad73c

browser-specific builds

afe57d1

andrewthauer reviewed Feb 2, 2018

View reviewed changes

manifest.json merging & npm script naming scheme

0ee9b66

sumitarora previously approved these changes Feb 2, 2018

View reviewed changes

andrewthauer reviewed Feb 6, 2018

View reviewed changes

andrewthauer previously approved these changes Feb 9, 2018

View reviewed changes

santiago-elustondo changed the title ~~(Work In Progress): FireFox compatibility using WebExtensions format.~~ FireFox compatibility using WebExtensions format. Feb 15, 2018

uncomment sentry_key check

a88c0b0

santiago-elustondo dismissed sumitarora’s stale review via a88c0b0 February 16, 2018 16:47

sumitarora previously approved these changes Mar 10, 2018

View reviewed changes

digitarald mentioned this pull request Mar 13, 2018

Increase max file size to 6 Mb mozilla/addons#662

Closed

add uglify

9e433d6

santiago-elustondo dismissed stale reviews from sumitarora and andrewthauer via 9e433d6 March 22, 2018 20:07

santiago-elustondo changed the base branch from master to dev March 22, 2018 20:09

Merge branch 'dev' into ff-compat

3cabcba

santiago-elustondo merged commit 6224b0f into rangle:dev Mar 22, 2018

santiago-elustondo deleted the ff-compat branch April 23, 2018 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FireFox compatibility using WebExtensions format. #1268

FireFox compatibility using WebExtensions format. #1268

santiago-elustondo commented Jan 24, 2018 •

edited

Loading

santiago-elustondo commented Jan 24, 2018 •

edited

Loading

andrewthauer Feb 1, 2018

andrewthauer Feb 1, 2018

sumitarora left a comment

andrewthauer left a comment

santiago-elustondo commented Feb 7, 2018

potch commented Feb 9, 2018

sumitarora commented Feb 9, 2018

potch commented Feb 12, 2018

abdulkareemnalband commented Mar 21, 2018

andrewthauer commented Mar 22, 2018

digitarald commented Mar 23, 2018

andrewthauer commented Mar 23, 2018

digitarald commented Mar 29, 2018

andrewthauer commented Mar 29, 2018 •

edited

Loading

digitarald commented Mar 30, 2018

andrewthauer commented Apr 12, 2018

		"build": "webpack --colors --display-error-details --display-cached",
		"build-chrome": "cross-env BROWSER=chrome npm run build",

FireFox compatibility using WebExtensions format. #1268

FireFox compatibility using WebExtensions format. #1268

Conversation

santiago-elustondo commented Jan 24, 2018 • edited Loading

santiago-elustondo commented Jan 24, 2018 • edited Loading

andrewthauer Feb 1, 2018

Choose a reason for hiding this comment

andrewthauer Feb 1, 2018

Choose a reason for hiding this comment

sumitarora left a comment

Choose a reason for hiding this comment

andrewthauer left a comment

Choose a reason for hiding this comment

santiago-elustondo commented Feb 7, 2018

potch commented Feb 9, 2018

sumitarora commented Feb 9, 2018

potch commented Feb 12, 2018

abdulkareemnalband commented Mar 21, 2018

andrewthauer commented Mar 22, 2018

digitarald commented Mar 23, 2018

andrewthauer commented Mar 23, 2018

digitarald commented Mar 29, 2018

andrewthauer commented Mar 29, 2018 • edited Loading

digitarald commented Mar 30, 2018

andrewthauer commented Apr 12, 2018

santiago-elustondo commented Jan 24, 2018 •

edited

Loading

santiago-elustondo commented Jan 24, 2018 •

edited

Loading

andrewthauer commented Mar 29, 2018 •

edited

Loading