Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

fix #1324 Define selectedComponentProperty in the way it could be redefined #1411

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

TaPO4eg3D
Copy link
Contributor

@TaPO4eg3D TaPO4eg3D commented Oct 31, 2019

fixes #1324

@yallen011
Copy link
Contributor

Does an issue already exist for this pr? If so could you please reference the issue, if not could you please create an issue for this pr giving a brief description. Also, specific if it is a breaking change, a fix or an enhancement.

Thank you for your submission and choosing to contributing to the Augury project.

@TaPO4eg3D
Copy link
Contributor Author

This PR fixes #1324
Please review

@feeloor feeloor self-requested a review November 13, 2019 08:53
Copy link
Contributor

@feeloor feeloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@feeloor
Copy link
Contributor

feeloor commented Nov 15, 2019

@TaPO4eg3D There seems to be some conflicts blocking the merge, could you resolve these conflicts?
Thanks!

@TaPO4eg3D
Copy link
Contributor Author

@feeloor Done

@feeloor
Copy link
Contributor

feeloor commented Nov 18, 2019

Great, thanks for your contributions @TaPO4eg3D!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.